Re: [PATCH v2] ftrace: Fix possible warning on checking all pages used in ftrace_process_locs()

[Steven Rostedt]

On Wed, 12 Jul 2023 04:16:30 +0800
Zheng Yejian <zhengyejian1@xxxxxxxxxx> wrote:

> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
> index 3740aca79fe7..b46e539dc085 100644
> --- a/kernel/trace/ftrace.c
> +++ b/kernel/trace/ftrace.c
> @@ -6473,7 +6473,9 @@ static int ftrace_process_locs(struct module *mod,
>  {
>  	struct ftrace_page *start_pg;
>  	struct ftrace_page *pg;
> +	struct ftrace_page *pg_unuse = NULL;
>  	struct dyn_ftrace *rec;
> +	unsigned long skipped = 0;
>  	unsigned long count;
>  	unsigned long *p;
>  	unsigned long addr;

Nit, to keep the upside-down-xmas-tree format:

	struct ftrace_page *pg_unuse = NULL;
	struct ftrace_page *start_pg;
	struct ftrace_page *pg;
	struct dyn_ftrace *rec;
	unsigned long skipped = 0;
	unsigned long count;
	unsigned long *p;
	unsigned long addr;

-- Steve