Re: [PATCH 15/18] soc: ti: Mover power-domain drivers to the genpd dir

From: Nishanth Menon
Date: Tue Jul 11 2023 - 08:49:30 EST


On 11:16-20230711, Ulf Hansson wrote:
> On Fri, 7 Jul 2023 at 19:50, Nishanth Menon <nm@xxxxxx> wrote:
> >
> > On 16:04-20230707, Ulf Hansson wrote:
> > > Cc: Nishanth Menon <nm@xxxxxx>
> > > Cc: Santosh Shilimkar <ssantosh@xxxxxxxxxx>
> > > Cc: Tero Kristo <kristo@xxxxxxxxxx>
> > > Signed-off-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
> > > ---
> > > MAINTAINERS | 3 ++-
> > > drivers/genpd/Makefile | 1 +
> > > drivers/genpd/ti/Makefile | 3 +++
> > > drivers/{soc => genpd}/ti/omap_prm.c | 0
> > > drivers/{soc => genpd}/ti/ti_sci_pm_domains.c | 0
> > > drivers/soc/ti/Makefile | 2 --
> > > 6 files changed, 6 insertions(+), 3 deletions(-)
> > > create mode 100644 drivers/genpd/ti/Makefile
> > > rename drivers/{soc => genpd}/ti/omap_prm.c (100%)
> > > rename drivers/{soc => genpd}/ti/ti_sci_pm_domains.c (100%)
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 9e580df3e5db..3cf16ffac892 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -21101,7 +21101,7 @@ F: drivers/irqchip/irq-ti-sci-inta.c
> > > F: drivers/irqchip/irq-ti-sci-intr.c
> > > F: drivers/reset/reset-ti-sci.c
> > > F: drivers/soc/ti/ti_sci_inta_msi.c
> > > -F: drivers/soc/ti/ti_sci_pm_domains.c
> > > +F: drivers/genpd/ti/ti_sci_pm_domains.c
> > > F: include/dt-bindings/soc/ti,sci_pm_domain.h
> > > F: include/linux/soc/ti/ti_sci_inta_msi.h
> > > F: include/linux/soc/ti/ti_sci_protocol.h
> > > @@ -21335,6 +21335,7 @@ L: linux-kernel@xxxxxxxxxxxxxxx
> > > L: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx (moderated for non-subscribers)
> > > S: Maintained
> > > T: git git://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
> > > +F: drivers/genpd/ti/omap_prm.c
> >
> > Probably the wrong place for this as omap_prm is'nt a keystone navigator
> > driver set. Maybe Tony has a suggestion?
>
> I guess we could add it to the OMAP2+ section then?

That would be my suggestion.

>
> In any case, I suggest we consider that as a separate patch on top, as
> I am just obeying to the existing pattern that the get_maintainers
> script provides.
>

OK. otherwise, this looks good to me.

Reviewed-by: Nishanth Menon <nm@xxxxxx>
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D