Re: [PATCH net-next][resend v1 1/1] netlink: Don't use int as bool in netlink_update_socket_mc()

From: Andy Shevchenko
Date: Tue Jul 11 2023 - 08:45:48 EST


On Tue, Jul 11, 2023 at 03:20:12PM +0300, Leon Romanovsky wrote:
> On Tue, Jul 11, 2023 at 01:54:18PM +0300, Andy Shevchenko wrote:
> > On Tue, Jul 11, 2023 at 12:21:12PM +0200, Paolo Abeni wrote:
> > > On Tue, 2023-07-11 at 09:33 +0300, Leon Romanovsky wrote:
> > > > On Mon, Jul 10, 2023 at 01:06:24PM +0300, Andy Shevchenko wrote:

...

> > > > So what is the outcome of "int - bool + bool" in the line above?
> >
> > The same as with int - int [0 .. 1] + int [0 .. 1].
>
> No, it is not. bool is defined as _Bool C99 type, so strictly speaking
> you are mixing types int - _Bool + _Bool.

1. The original code already does that. You still haven't reacted on that.
2. Is what you are telling a problem?

--
With Best Regards,
Andy Shevchenko