Re: [PATCH] cgroup: remove unneeded return value of cgroup_rm_cftypes_locked()

From: Michal Koutný
Date: Tue Jul 11 2023 - 07:21:46 EST


On Tue, Jul 11, 2023 at 10:58:48AM +0800, Miaohe Lin <linmiaohe@xxxxxxxxxx> wrote:
> +/* It builds upon cgroup_addrm_files()'s. */
> static void cgroup_rm_cftypes_locked(struct cftype *cfts)
> {
> lockdep_assert_held(&cgroup_mutex);
>

I meant adding the reasoning to the commit message -- swallowing errors
on removal is fine because cgroup_addrm_files() won't fail at removal.
It's a minor remark for the future readers ;-)

Michal

Attachment: signature.asc
Description: PGP signature