RE: [PATCH v2] RDMA/qedr: Remove a duplicate assignment in qedr_create_gsi_qp()

From: Alok Prasad
Date: Tue Jul 11 2023 - 02:18:23 EST



> -----Original Message-----
> From: Minjie Du <duminjie@xxxxxxxx>
> Sent: 05 July 2023 16:10
> To: Markus.Elfring@xxxxxx; Michal Kalderon <mkalderon@xxxxxxxxxxx>; Ariel Elior <aelior@xxxxxxxxxxx>; Jason Gunthorpe
> <jgg@xxxxxxxx>; Leon Romanovsky <leon@xxxxxxxxxx>; open list:QLOGIC QL4xxx RDMA DRIVER <linux-rdma@xxxxxxxxxxxxxxx>; open
> list <linux-kernel@xxxxxxxxxxxxxxx>
> Cc: opensource.kernel@xxxxxxxx; Minjie Du <duminjie@xxxxxxxx>
> Subject: [PATCH v2] RDMA/qedr: Remove a duplicate assignment in qedr_create_gsi_qp()
>
> Delete a duplicate statement from this function implementation.
>
> Signed-off-by: Minjie Du <duminjie@xxxxxxxx>
> ---
> drivers/infiniband/hw/qedr/qedr_roce_cm.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/qedr/qedr_roce_cm.c b/drivers/infiniband/hw/qedr/qedr_roce_cm.c
> index 05307c148..859f66a51 100644
> --- a/drivers/infiniband/hw/qedr/qedr_roce_cm.c
> +++ b/drivers/infiniband/hw/qedr/qedr_roce_cm.c
> @@ -354,7 +354,6 @@ int qedr_create_gsi_qp(struct qedr_dev *dev, struct ib_qp_init_attr *attrs,
> /* the GSI CQ is handled by the driver so remove it from the FW */
> qedr_destroy_gsi_cq(dev, attrs);
> dev->gsi_rqcq->cq_type = QEDR_CQ_TYPE_GSI;
> - dev->gsi_rqcq->cq_type = QEDR_CQ_TYPE_GSI;
>
> DP_DEBUG(dev, QEDR_MSG_GSI, "created GSI QP %p\n", qp);
>
> --
> 2.39.0


Thanks for making the change.

Acked-by: Alok Prasad <palok@xxxxxxxxxxx>