[PATCH] drm/nouveau/flcn/cmdq: Move assignment outside if condition

From: sunran001
Date: Tue Jul 11 2023 - 01:55:39 EST


Fixes the following checkpatch errors:

ERROR: do not use assignment in if condition

Signed-off-by: Ran Sun <sunran001@xxxxxxxxxx>
---
drivers/gpu/drm/nouveau/nvkm/falcon/cmdq.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/nouveau/nvkm/falcon/cmdq.c b/drivers/gpu/drm/nouveau/nvkm/falcon/cmdq.c
index 211ebe7afac6..a8beb55097a6 100644
--- a/drivers/gpu/drm/nouveau/nvkm/falcon/cmdq.c
+++ b/drivers/gpu/drm/nouveau/nvkm/falcon/cmdq.c
@@ -203,7 +203,8 @@ nvkm_falcon_cmdq_new(struct nvkm_falcon_qmgr *qmgr, const char *name,
{
struct nvkm_falcon_cmdq *cmdq = *pcmdq;

- if (!(cmdq = *pcmdq = kzalloc(sizeof(*cmdq), GFP_KERNEL)))
+ cmdq = *pcmdq = kzalloc(sizeof(*cmdq), GFP_KERNEL);
+ if (!cmdq)
return -ENOMEM;

cmdq->qmgr = qmgr;