Re: [PATCH] io_uring: Redefined the meaning of io_alloc_async_data's return value

From: Christoph Hellwig
Date: Tue Jul 11 2023 - 01:06:32 EST


On Mon, Jul 10, 2023 at 12:58:58PM -0400, Gabriel Krisman Bertazi wrote:
> practice to change the symbol, making the change hard to miss. Or
> make the function return int instead of bool, which preserves the
> interface and is a common C idiom. Or leave it as it is, which is quite
> readable already..

Yeah, returning -ENOMEM and 0 would make a lot more sense here. But I'd
only change it if we have any good reason to touch the interface anyway.