RE: [EXT] Re: [PATCH v3 2/7] arm64: dts: imx93-11x11-evk: added ele-mu

From: Pankaj Gupta
Date: Mon Jul 10 2023 - 13:47:59 EST




> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Sent: Friday, June 16, 2023 6:52 PM
> To: Pankaj Gupta <pankaj.gupta@xxxxxxx>; robh+dt@xxxxxxxxxx;
> krzysztof.kozlowski+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx;
> shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx;
> festevam@xxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>;
> devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Gaurav
> Jain <gaurav.jain@xxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx
> Subject: [EXT] Re: [PATCH v3 2/7] arm64: dts: imx93-11x11-evk: added ele-
> mu
>
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
>
>
> On 16/06/2023 20:11, Pankaj Gupta wrote:
> > adde support for ele-mu for imx93-11x11-evk.
> >
> > Signed-off-by: Pankaj Gupta <pankaj.gupta@xxxxxxx>
>
>
> > #include <dt-bindings/clock/imx93-clock.h> @@ -788,5 +788,15 @@
> > media_blk_ctrl: system-controller@4ac10000 {
> > #power-domain-cells = <1>;
> > status = "disabled";
> > };
> > +
> > + ele_mu: ele-mu {
> > + compatible = "fsl,imx93-ele";
> > + mboxes = <&s4muap 0 0 &s4muap 1 0>;
> > + mbox-names = "tx", "rx";
> > + fsl,ele_mu_did = <3>;
> > + fsl,ele_mu_id = <2>;
> > + fsl,ele_mu_max_users = <4>;
> > + status = "okay";
>
> Can you do some internal review first?
Done.
- Removed non h/w dependent DT binding : " fsl,ele_mu_max_users".
- To denote the kernel driver for interacting with Secure-Enclave Firmware; re-named to "se-fw" from "ele-mu".


>
> Best regards,
> Krzysztof