Re: [PATCH] cgroup: remove unneeded return value of cgroup_rm_cftypes_locked()

From: Michal Koutný
Date: Mon Jul 10 2023 - 11:46:19 EST


Hi.

On Sat, Jul 01, 2023 at 03:38:56PM +0800, Miaohe Lin <linmiaohe@xxxxxxxxxx> wrote:
> The return value of cgroup_rm_cftypes_locked() is always 0. So remove
> it to simplify the code. No functional change intended.

I'd add a comment that it builds upon cgroup_addrm_files()'s:
> For removals, this function never fails.

> Signed-off-by: Miaohe Lin <linmiaohe@xxxxxxxxxx>
> ---
> kernel/cgroup/cgroup.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)

Reviewed-by: Michal Koutný <mkoutny@xxxxxxxx>

Attachment: signature.asc
Description: PGP signature