Re: [PATCH v4 4/9] acpi: Rename ACPI_PDC constants

From: Andy Shevchenko
Date: Mon Jul 10 2023 - 10:20:25 EST


On Mon, Jul 10, 2023 at 05:03:32PM +0300, Michal Wilczynski wrote:
> ACPI_PDC constants prefix suggest that those constants are only relevant
> in the context of the _PDC method. This is not true, as they can also be
> used in _OSC context. Change prefix to more generic ACPI_PROC_CAP, that
> better describe the purpose of those constants as they describe bits in
> processor capabilities buffer. Rename pdc_intel.h to proc_cap_intel.h to
> reflect the change in the prefix.

...

> - /* Ask the Hypervisor whether to clear ACPI_PDC_C_C2C3_FFH. If so,
> + /* Ask the Hypervisor whether to clear ACPI_PROC_CAP_C_C2C3_FFH. If so,
> * don't expose MWAIT_LEAF and let ACPI pick the IOPORT version of C3.
> */

/*
* While at it, you can fix multi-line
* comment style. It supposed to be
* like in this example.
*/

I don't know if resend is required, I would wait for Rafael to comment on this.

--
With Best Regards,
Andy Shevchenko