Re: [PATCH] tpm: return false from tpm_amd_is_rng_defective on non-x86 platforms

From: Jarkko Sakkinen
Date: Mon Jul 10 2023 - 09:31:24 EST


On Fri Jul 7, 2023 at 11:18 PM EEST, Jerry Snitselaar wrote:
> On Fri, Jul 07, 2023 at 06:07:49PM +0200, Linux regression tracking (Thorsten Leemhuis) wrote:
> > Hi, Thorsten here, the Linux kernel's regression tracker. Top-posting
> > for once, to make this easily accessible to everyone.
> >
> > So what's the way forward now? It sounded like Jarkko wanted to apply
> > the patch from this thread days ago, but that didn't happen afaics. Then
> > below message showed up, but Marios patch also wasn't applied.
> >
> > Is this intentional, or did something somewhere fall through the cracks?
> >
> > Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
>
> I haven't seen any update to Jarkko's repo.
>
> My patch resolves the immediate issue being seen on the ppc system,
> and was mostly just me asking why even go through this amd specific
> code on non-x86 systems.
>
> The vio bus shutdown code only does the remove call when kexec is in
> progress. The pnp and platform bus type shutdown calls do not do
> something similar so maybe the check in Mario's patch isn't needed,
> but I don't think it would hurt to have it in there.

The patch has been applied. I'm sending pull request for rc2 today.

The merge window was a bit conflicting with the summer season, and
also relocating.

BR, Jarkko