Re: [PATCH] memory: tegra: Add dummy implementation on Tegra194

From: Krzysztof Kozlowski
Date: Mon Jul 10 2023 - 09:29:23 EST


On 10/07/2023 15:06, Thierry Reding wrote:
> On Mon, Jul 10, 2023 at 12:10:43PM +0200, Krzysztof Kozlowski wrote:
>> On 29/06/2023 18:01, Thierry Reding wrote:
>>> From: Thierry Reding <treding@xxxxxxxxxx>
>>>
>>> With the introduction of commit 9365bf006f53 ("PCI: tegra194: Add
>>> interconnect support in Tegra234"), the PCI driver on Tegra194 and later
>>> requires an interconnect provider. However, a provider is currently only
>>> exposed on Tegra234 and this causes PCI on Tegra194 to defer probe
>>> indefinitely.
>>>
>>> Fix this by adding a dummy implementation on Tegra194. This allows nodes
>>> to be provided to interconnect consumers, but doesn't do any bandwidth
>>> accounting or frequency scaling.
>>>
>>> Fixes: 9365bf006f53 ("PCI: tegra194: Add interconnect support in Tegra234")
>>> Reported-by: Jon Hunter <jonathanh@xxxxxxxxxx>
>>
>> Applied with checkpatch warning. Please be sure you run checkpatch
>> before sending the patches.
>
> Are you referring to the Reported-by/Closes complaint?

Yes.

> I didn't include
> a URL here because this came from an internal test report and there's no
> corresponding public reference.

Ah, ok, apologies for pickiness then. :)

>
> I suppose I could've left out the Reported-by altogether.

I think it is fine. Checkpatch warning is just advisory.


Best regards,
Krzysztof