Re: [RFC PATCH] wifi: iwlwifi: remove 'use_tfh' config to fix crash

[Jeff Chua]

On Mon, Jul 10, 2023 at 9:53 AM Zhang, Rui <rui.zhang@xxxxxxxxx> wrote:
>
> On Sun, 2023-07-09 at 20:13 +0200, Johannes Berg wrote:
> > From: Johannes Berg <johannes.berg@xxxxxxxxx>
> >
> > This is equivalent to 'gen2', and it's confusing to have two
> > of the same configs. The split config patch actually had been
> > originally developed after this, and didn't add the use_tfh
> > in the new configs because they were copied to the new files
> > after ...
> >
> > There's clearly still an unwind error in iwl_txq_gen2_init()
> > since it crashes if something fails there, but the reason it
> > fails in the first place is due to the gen2/use_tfh confusion.
> >
> > Reported-by: Jeff Chua <jeff.chua.linux@xxxxxxxxx>
> > Reported-by: "Zhang, Rui" <rui.zhang@xxxxxxxxx>
> > Link: https://bugzilla.kernel.org/show_bug.cgi?id=217622
> > Link:
> > https://lore.kernel.org/all/9274d9bd3d080a457649ff5addcc1726f08ef5b2.camel@xxxxxxxxxxx/
> > Link:
> > https://lore.kernel.org/all/CAAJw_Zug6VCS5ZqTWaFSr9sd85k%3DtyPm9DEE%2BmV%3DAKoECZM%2BsQ@xxxxxxxxxxxxxx/
> > Fixes: 19898ce9cf8a ("wifi: iwlwifi: split 22000.c into multiple
> > files")
> > Signed-off-by: Johannes Berg <johannes.berg@xxxxxxxxx>
>
> Hi, Johannes,
>
> Thanks for the patch. It fixes the problem on my side.
>
> Tested-by: Zhang Rui <rui.zhang@xxxxxxxxx>
>
> thanks,
> rui


Johannes,

Fixed as well! Thank you!

cc to those I've posted before as well.

Jeff