Re: [PATCH] signal: remove duplicate include header in signal.c

From: Haifeng Xu
Date: Mon Jul 10 2023 - 06:14:17 EST


On 2023/7/10 15:23, ye.xingchen@xxxxxxxxxx wrote:
> From: Ye Xingchen <ye.xingchen@xxxxxxxxxx>
>
> linux/file.h is included more than once.

Can you point out which files have contained file.h?
Though file.h is included more than once, but it has used the macro "#ifndef / #define" to avoid redefinition.
So what’s your concern about this?

Thanks, Haifeng.

>
> Signed-off-by: Ye Xingchen <ye.xingchen@xxxxxxxxxx>
> ---
> kernel/signal.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/signal.c b/kernel/signal.c
> index 9a3ff8157ceb..b1da4e81bde6 100644
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -25,7 +25,6 @@
> #include <linux/mm.h>
> #include <linux/proc_fs.h>
> #include <linux/tty.h>
> -#include <linux/file.h>
> #include <linux/binfmts.h>
> #include <linux/coredump.h>
> #include <linux/security.h>