Re: [PATCH 1/8] mm: memory-failure: fix potential permanently locked hpage

From: Miaohe Lin
Date: Mon Jul 10 2023 - 04:27:01 EST


On 2023/7/10 15:56, Naoya Horiguchi wrote:
> On Sat, Jul 08, 2023 at 04:57:37PM +0800, Miaohe Lin wrote:
>> If hpage isn't Hugetlb page, MF_DELAYED is returned without unlock hpage
>> leading to hpage permanently locked. But this shouldn't trigger in the
>> real world because this PageHuge() check is just for potential problems.
>
> Right, so this if-block is dead code, how about simply removing it?

>From the current code of view, I think this if-block is actually dead code and won't catch
anything too. So removing it makes sense to me. Will do it in v2.

Thanks Naoya.