Re: [PATCH v3 RESEND] x86/mm: Fix PAT bit missing from page protection modify mask

From: Borislav Petkov
Date: Mon Jul 10 2023 - 04:05:50 EST


On Mon, Jul 10, 2023 at 09:36:14AM +0200, Janusz Krzysztofik wrote:
> Assume that adding _PAGE_PAT to _PAGE_CHG_MASK doesn't break pte_modify()
> and its users, and go for it. Also, add _PAGE_PAT_LARGE to

That's my only worry.

I'd suggest we queue this but not send it to Linus now. Instead, let it
cook in linux-next for the whole 6.5 release cycle so that it can get at
least *some* testing.

Because if we send it now and something else obscure breaks in a weird
way in his tree, then we'll have to scramble to fix that too and it'll
be one helluva mess.

Dave?

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette