Re: [PATCH] kernel: params: Remove unnecessary ‘0’ values from err

From: Randy Dunlap
Date: Sun Jul 09 2023 - 23:33:50 EST




On 7/11/23 12:43, Li zeming wrote:
> err is assigned first, so it does not need to initialize the assignment.
>
> Signed-off-by: Li zeming <zeming@xxxxxxxxxxxx>

Reviewed-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>

Thanks.

> ---
> kernel/params.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/params.c b/kernel/params.c
> index 6a7548979aa9..f8837a5f2c3e 100644
> --- a/kernel/params.c
> +++ b/kernel/params.c
> @@ -331,7 +331,7 @@ EXPORT_SYMBOL(param_ops_bool);
>
> int param_set_bool_enable_only(const char *val, const struct kernel_param *kp)
> {
> - int err = 0;
> + int err;
> bool new_value;
> bool orig_value = *(bool *)kp->arg;
> struct kernel_param dummy_kp = *kp;

--
~Randy