Re: [PATCH v1] fs:smb:Fix unsigned expression compared with zero

From: Namjae Jeon
Date: Sat Jul 08 2023 - 20:41:18 EST


2023-07-04 22:58 GMT+09:00, Tom Talpey <tom@xxxxxxxxxx>:
> On 7/4/2023 4:58 AM, Namjae Jeon wrote:
>> 2023-07-04 16:40 GMT+09:00, Wang Ming <machel@xxxxxxxx>:
>>> The return value of the ksmbd_vfs_getcasexattr() is signed.
>>> However, the return value is being assigned to an unsigned
>>> variable and subsequently recasted, causing warnings. Use
>>> a signed type.
>>>
>>> Signed-off-by: Wang Ming <machel@xxxxxxxx>
>> Acked-by: Namjae Jeon <linkinjeon@xxxxxxxxxx>
>>
>> Thanks for your patch!
>>
>
> FYI, this is missing my previous Acked-by. The updated changelog
> otherwise looks good.
Applied it with your acked-by tag to #ksmbd-for-next-next.

Thanks!
>
> Tom.
>