Re: RE: [PATCH net v2 1/2] net: ll_temac: Fix DMA resources leak

From: Christophe JAILLET
Date: Sat Jul 08 2023 - 09:16:06 EST


Le 14/03/2023 à 06:15, Katakam, Harini a écrit :
Hi Jakub, Jonas,

-----Original Message-----
From: Jakub Kicinski <kuba@xxxxxxxxxx>
Sent: Tuesday, March 14, 2023 12:19 AM
To: Jonas Suhr Christensen <jsc@xxxxxxxxxxxxxx>; Katakam, Harini
<harini.katakam@xxxxxxx>
Cc: Paolo Abeni <pabeni@xxxxxxxxxx>; netdev@xxxxxxxxxxxxxxx; David S.
Miller <davem@xxxxxxxxxxxxx>; Eric Dumazet <edumazet@xxxxxxxxxx>;
Michal Simek <michal.simek@xxxxxxxxxx>; Haoyue Xu
<xuhaoyue1@xxxxxxxxxxxxx>; huangjunxian <huangjunxian6@xxxxxxxxxxxxx>;
Wang Qing <wangqing@xxxxxxxx>; Yang Yingliang
<yangyingliang@xxxxxxxxxx>; Esben Haabendal <esben@xxxxxxxxxx>;
linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
Subject: Re: [PATCH net v2 1/2] net: ll_temac: Fix DMA resources leak

On Mon, 13 Mar 2023 19:37:00 +0100 Jonas Suhr Christensen wrote:
On Tue, Feb 7, 2023, at 19:42, Jakub Kicinski wrote:
On Tue, 07 Feb 2023 12:36:11 +0100 Paolo Abeni wrote:
You can either try change to phys type to __be32 (likely not
suitable for -net and possibly can introduce even more warnings
elsewhere)

FWIW that seems like the best option to me as well. Let's ignore the
sparse warning for v3 and try to switch phys to __be32 in a separate
patch for net-next. No point adding force casts just to have to
remove them a week later, given how prevalent the problem is.

or explicitly cast the argument.

I no longer have access to the hardware, so I'm not rewriting the
batch. Feel free to take ownership of it and fix what's needed.

Ack.

Harini, are you the designated maintainer for this driver? Could you add a
MAINTAINERS entry for it? I don't see one right now.
And possibly pick up these patches / fix the problem, if you have the cycles?

Sure, Srinivas (cced) will pick up this series and send a v3.
I'll get back on the state of this IP/driver for the maintainers list. Will include
that patch in the beginning of the series as well.

Regards,
Harini


Hi,

this patch, or an updated version, has not reached -next yet.

Does someone still working on it, or did it got lost?

CJ