Re: [PATCH v3 2/4] mm/hwpoison: check if a subpage of a hugetlb folio is raw HWPOISON

From: Andrew Morton
Date: Fri Jul 07 2023 - 17:05:58 EST


On Fri, 7 Jul 2023 21:31:39 +0100 Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote:

> On Fri, Jul 07, 2023 at 08:19:02PM +0000, Jiaqi Yan wrote:
> > Add the functionality, is_raw_hwp_subpage, to tell if a subpage of a
>
> This is incorrect naming. "subpage" was needed before we had the
> folio concept, but it should not be used any more. We have folios
> and pages now.
>
> Also, abbreviating "hwpoison" as "hwp" seems like a bad idea to me.
> hwp is already used as an acronym by acpi, intel_pstate, some clock
> drivers, an ethernet driver, and a scsi driver.

Thanks, Matthew. I'll merge v3 so we hit next -next (which actually
won't be until Monday), and add a note that v4 is expected.