Re: [PATCH 1/2] mm: lock a vma before stack expansion

From: Matthew Wilcox
Date: Fri Jul 07 2023 - 16:03:28 EST


On Fri, Jul 07, 2023 at 10:00:42PM +0200, Markus Elfring wrote:
>
> > write-locked to prevent page faults into the VMA being expanded. Add
> > the necessary locking.
>
> 1. Would it a bit nicer to put the second sentence on a separate line
> in such a change description?
>
> 2. I noticed that you put the address “stable@xxxxxxxxxxxxxxx”
> into the message field “Cc”.
> Would you like to specify such a hint as a tag?
>
> See also:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.4#n264
>
> 3. How do you think about to add the tag “Fixes”?
>
> 4. Will a cover letter become helpful also for the presented small patch series?

Markus, your nitpicking is not useful. Please stop.