Re: [PATCH v2 06/11] ata: sata_rcar: Remove unnecessary return value check

From: Sergey Shtylyov
Date: Fri Jul 07 2023 - 15:07:07 EST


On 7/7/23 12:55 PM, Yangtao Li wrote:

> As commit a85a6c86c25b ("driver core: platform: Clarify that IRQ 0
> is invalid") says, there is no need to check if the platform_get_irq
> return value is 0. Let's remove it.

No, that patch still allows returning IRQ0, actually you need:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ce753ad1549cbe9ccaea4c06a1f5fa47432c8289

> Signed-off-by: Yangtao Li <frank.li@xxxxxxxx>

Aside from that:

Reviewed-by: Sergey Shtylyov <s.shtylyov@xxxxxx>

[...]

MBR, Sergey