Re: [PATCH v2 1/2] dt-bindings: mtd: Add SEAMA partition bindings

[Linus Walleij]

On Wed, Jul 5, 2023 at 9:51 PM Rob Herring <robh@xxxxxxxxxx> wrote:
> On Wed, Jul 05, 2023 at 12:17:46PM +0200, Linus Walleij wrote:

> >    - $ref: redboot-fis.yaml
> > +  - $ref: seama.yaml
>
> I think this is in the wrong place. These should be device level
> partitioning schemas, not an individual partition type. (Though nesting
> is possible)

OK it wasn't there in v1, then Krzysztof said it should be there
(if I understood correctly) and I will remove it again then.

> > +select: false
>
> Remove this and your example will fail. You need unevaluatedProperties.

OK

> There's a problem in partitions.yaml. It never gets applied, so this
> schema never gets applied. The default 'select' is generated based on
> $nodename or compatible, but it has neither. This needs some more
> thought on how to fix given the variable way partitions can be combined.
> Probably at a minimum, all the 'select: false' need to be removed.

I don't think I can fix this problem, I'm not that good with schema.
I don't even understand the thinking around the existing partitions.yaml.

Yours,
Linus Walleij