Re: [PATCH 1/2] mm: compaction: use the correct type of list for free pages

[David Hildenbrand]

On 07.07.23 10:51, Baolin Wang wrote:
> Use the page->buddy_list instead of page->lru to clarify the correct type
> of list for free pages.
>
> Signed-off-by: Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx>
> ---
>   mm/compaction.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/compaction.c b/mm/compaction.c
> index dbc9f86b1934..43358efdbdc2 100644
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -1500,7 +1500,7 @@ static void fast_isolate_freepages(struct compact_control *cc)
>   
>   		spin_lock_irqsave(&cc->zone->lock, flags);
>   		freelist = &area->free_list[MIGRATE_MOVABLE];
> -		list_for_each_entry_reverse(freepage, freelist, lru) {
> +		list_for_each_entry_reverse(freepage, freelist, buddy_list) {
>   			unsigned long pfn;
>   
>   			order_scanned++;
> @@ -1883,7 +1883,7 @@ static unsigned long fast_find_migrateblock(struct compact_control *cc)
>   
>   		spin_lock_irqsave(&cc->zone->lock, flags);
>   		freelist = &area->free_list[MIGRATE_MOVABLE];
> -		list_for_each_entry(freepage, freelist, lru) {
> +		list_for_each_entry(freepage, freelist, buddy_list) {
>   			unsigned long free_pfn;
>   
>   			if (nr_scanned++ >= limit) {

Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>

--
Cheers,

David / dhildenb