Re: [PATCH v3] wifi: ath9k: fix printk specifier

[Dongliang Mu]

On 7/7/23 00:04, Jonas Gorski wrote:
> On Thu, 6 Jul 2023 at 13:39, Toke Høiland-Jørgensen <toke@xxxxxxx> wrote:
> > Dongliang Mu <dzm91@xxxxxxxxxxx> writes:
> >
> > > Smatch reports:
> > >
> > > ath_pci_probe() warn: argument 4 to %lx specifier is cast from pointer
> > > ath_ahb_probe() warn: argument 4 to %lx specifier is cast from pointer
> > >
> > > Fix it by modifying %lx to %p in printk.
> > >
> > > Signed-off-by: Dongliang Mu <dzm91@xxxxxxxxxxx>
> > Third time is the charm! :)
> >
> > Acked-by: Toke Høiland-Jørgensen <toke@xxxxxxx>
> But do we *want* to replace %lx with %p? Because this now causes a
> change in behavior, as the kernel will omit the pointer's address,
> while before it printed the actual memory address. Using %px would
> have kept the original behavior.

This is why I made mistake in the patch submission. I think %px is more 
suitable and generate a patch, but then checkpatch.pl thinks I should 
use %p instead.

I change the code change, but forget the commit message.

> So if the change is desired, it should be noted in the commit message.
>
> best Regards,
> Jonas