Re: [PATCH] tools: testing: Corrected a clerical error

[Hou Tao]

Hi,

On 7/6/2023 5:53 PM, Lu Hongfei wrote:
> When wrapping code, use ';' better than using ',' which is more
> in line with the coding habits of most engineers.
>
> Signed-off-by: Lu Hongfei <luhongfei@xxxxxxxx>
> ---
>  tools/testing/selftests/bpf/benchs/bench_ringbufs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/benchs/bench_ringbufs.c b/tools/testing/selftests/bpf/benchs/bench_ringbufs.c
> index 3ca14ad36607..e1ee979e6acc 100644
> --- a/tools/testing/selftests/bpf/benchs/bench_ringbufs.c
> +++ b/tools/testing/selftests/bpf/benchs/bench_ringbufs.c
> @@ -399,7 +399,7 @@ static void perfbuf_libbpf_setup(void)
>  	ctx->skel = perfbuf_setup_skeleton();
>  
>  	memset(&attr, 0, sizeof(attr));
> -	attr.config = PERF_COUNT_SW_BPF_OUTPUT,
> +	attr.config = PERF_COUNT_SW_BPF_OUTPUT;
>  	attr.type = PERF_TYPE_SOFTWARE;
>  	attr.sample_type = PERF_SAMPLE_RAW;
>  	/* notify only every Nth sample */

Acked-by: Hou Tao <houtao1@xxxxxxxxxx>

Please update the subject of the patch in v2. The subject should be
something like: "[PATCH bpf-next] selftests/bpf: xxxxxx"

Just be curious. How do you find out the typo ? Is there any similar
typos in bpf selftests and could you please fix these typos as well ?