Re: [PATCH 14/23] i2c: nomadik: Remove #ifdef guards for PM related functions

From: Linus Walleij
Date: Thu Jul 06 2023 - 13:13:11 EST


On Wed, Jul 5, 2023 at 10:43 PM Paul Cercueil <paul@xxxxxxxxxxxxxxx> wrote:

> Use the new PM macros for the suspend and resume functions to be
> automatically dropped by the compiler when CONFIG_PM or
> CONFIG_PM_SLEEP are disabled, without having to use #ifdef guards.
>
> This has the advantage of always compiling these functions in,
> independently of any Kconfig option. Thanks to that, bugs and other
> regressions are subsequently easier to catch.
>
> Signed-off-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx>

Looks correct!
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij