Re: [RFC PATCH 01/11] iov_iter: Fix comment refs to iov_iter_get_pages/pages_alloc()

From: Christoph Hellwig
Date: Thu Jul 06 2023 - 11:21:33 EST


On Fri, Jun 30, 2023 at 04:25:14PM +0100, David Howells wrote:
> /*
> * FOLL_LONGTERM indicates that the page will be held for an indefinite
> * time period _often_ under userspace control. This is in contrast to
> - * iov_iter_get_pages(), whose usages are transient.
> + * iov_iter_get_pages2(), whose usages are transient.
> */

I don't think this should refer to iov_iter_get_pages* at all. The
flag should document that actual get/pin_user interfaces and not refer
to a (deprecated) interface built on top of it.