Re: [PATCH v1 3/3] arm64: dts: rockchip: Add Radxa ROCK 4SE

[Christopher Obbard]

Hi Krzysztof,

On Wed, 2023-07-05 at 17:53 +0200, Krzysztof Kozlowski wrote:
> On 05/07/2023 16:10, Christopher Obbard wrote:
> > Add board-specific devicetree file for the RK3399T-based Radxa ROCK 4SE
> > board. This board offers similar peripherals in a similar form-factor to
> > the existing ROCK Pi 4B but uses the cost-optimised RK3399T processor
> > (which has different OPP table than the RK3399) and other minimal hardware
> > changes.
> > 
> > Signed-off-by: Christopher Obbard <chris.obbard@xxxxxxxxxxxxx>
> > ---
> > 
> 
> 
> > +
> > +&sdio0 {
> > +       status = "okay";
> > +
> > +       brcmf: wifi@1 {
> > +               compatible = "brcm,bcm4329-fmac";
> > +               reg = <1>;
> > +               interrupt-parent = <&gpio0>;
> > +               interrupts = <RK_PA3 GPIO_ACTIVE_HIGH>;
> 
> I just send a patch to fix this in some files, so let's try keep it
> good. Use proper interrupt type, not none.

Thank you for your review. I missed that patch, sent only a few hours before mine. I will address this in v2.


Cheers!

Chris