Re: [PATCH v2 38/92] efs: convert to ctime accessor functions

[Jan Kara]

On Wed 05-07-23 15:01:03, Jeff Layton wrote:
> In later patches, we're going to change how the inode's ctime field is
> used. Switch to using accessor functions instead of raw accesses of
> inode->i_ctime.
> 
> Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@xxxxxxx>

								Honza

> ---
>  fs/efs/inode.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/efs/inode.c b/fs/efs/inode.c
> index 3ba94bb005a6..3789d22ba501 100644
> --- a/fs/efs/inode.c
> +++ b/fs/efs/inode.c
> @@ -105,8 +105,8 @@ struct inode *efs_iget(struct super_block *super, unsigned long ino)
>  	inode->i_size  = be32_to_cpu(efs_inode->di_size);
>  	inode->i_atime.tv_sec = be32_to_cpu(efs_inode->di_atime);
>  	inode->i_mtime.tv_sec = be32_to_cpu(efs_inode->di_mtime);
> -	inode->i_ctime.tv_sec = be32_to_cpu(efs_inode->di_ctime);
> -	inode->i_atime.tv_nsec = inode->i_mtime.tv_nsec = inode->i_ctime.tv_nsec = 0;
> +	inode_set_ctime(inode, be32_to_cpu(efs_inode->di_ctime), 0);
> +	inode->i_atime.tv_nsec = inode->i_mtime.tv_nsec = 0;
>  
>  	/* this is the number of blocks in the file */
>  	if (inode->i_size == 0) {
> -- 
> 2.41.0
> 
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR