回复: [PATCH] block: mq-deadline: rename sort_list to sort_rb

[李培锋(wink)]

>>> Mq-deadline would store request in list:fifo_list and 
>>> rb_tree:sort_list, and sort_list should be renamed to sort_rb which 
>>> is beneficial for understanding.

>>Huh? I think this patch makes the code less readable instead of more readable ...

>Huh? Maybe we had different opinions about it, I thinks the essence of this word is 'sort'
>So that reader can get the meaning of it easily. And in my mind, *_rb is more reasonable for rb_root ratherthan *_list for reader.

Hi Sir：
Should it be merged for the above reason? Hope for your reply, thanks.

-----邮件原件-----
发件人: 李培锋(wink) 
发送时间: 2023年7月5日 8:31
收件人: Bart Van Assche <bvanassche@xxxxxxx>; axboe@xxxxxxxxx
抄送: linux-block@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; 张诗明(Simon Zhang) <zhangshiming@xxxxxxxx>; 郭健 <guojian@xxxxxxxx>
主题: 回复: [PATCH] block: mq-deadline: rename sort_list to sort_rb

>> Mq-deadline would store request in list:fifo_list and 
>> rb_tree:sort_list, and sort_list should be renamed to sort_rb which 
>> is beneficial for understanding.

>Huh? I think this patch makes the code less readable instead of more readable ...

Huh? Maybe we had different opinions about it, I thinks the essence of this word is 'sort'
So that reader can get the meaning of it easily. And in my mind, *_rb is more reasonable for rb_root ratherthan *_list for reader.

-----邮件原件-----
发件人: Bart Van Assche <bvanassche@xxxxxxx>
发送时间: 2023年7月4日 22:13
收件人: 李培锋(wink) <lipeifeng@xxxxxxxx>; axboe@xxxxxxxxx
抄送: linux-block@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; 张诗明(Simon Zhang) <zhangshiming@xxxxxxxx>; 郭健 <guojian@xxxxxxxx>
主题: Re: [PATCH] block: mq-deadline: rename sort_list to sort_rb

On 7/3/23 21:06, lipeifeng@xxxxxxxx wrote:
> Mq-deadline would store request in list:fifo_list and 
> rb_tree:sort_list, and sort_list should be renamed to sort_rb which is 
> beneficial for understanding.

Huh? I think this patch makes the code less readable instead of more readable ...

Bart.