Re: [RFC PATCH 02/14] tracing/filters: Enable filtering a cpumask field by another cpumask
From: Steven Rostedt
Date: Wed Jul 05 2023 - 14:54:40 EST
On Wed, 5 Jul 2023 19:12:44 +0100
Valentin Schneider <vschneid@xxxxxxxxxx> wrote:
> + /* Copy the cpulist between { and } */
> + tmp = kmalloc(i - maskstart + 1, GFP_KERNEL);
> + strncpy(tmp, str + maskstart, i - maskstart);
> + tmp[i - maskstart] = '\0';
> +
You can replace the above with:
tmp = kmalloc((i - maskstart) + 1, GFP_KERNEL);
strscpy(tmp, str + maskstart, (i - maskstart) + 1);
As strscpy() adds the nul terminating character, not to mention that
strncpy() is deprecated (see Documentation/process/deprecated.rst).
-- Steve