Re: [PATCH 1/2] arm64: dts: qcom: qdu1000-idp: Update reserved memory region

[Krzysztof Kozlowski]

On 05/07/2023 13:08, Konrad Dybcio wrote:
> On 5.07.2023 11:42, Dmitry Baryshkov wrote:
>> On Wed, 5 Jul 2023 at 10:06, Komal Bajaj <quic_kbajaj@xxxxxxxxxxx> wrote:
>>>
>>>
>>>
>>> On 7/5/2023 11:19 AM, Dmitry Baryshkov wrote:
>>>> On Wed, 5 Jul 2023 at 08:40, Komal Bajaj <quic_kbajaj@xxxxxxxxxxx> wrote:
>>>>> Add missing reserved regions as described in QDU1000 memory map.
>>>>>
>>>>> Signed-off-by: Komal Bajaj <quic_kbajaj@xxxxxxxxxxx>
>>>>> ---
>>>>>   arch/arm64/boot/dts/qcom/qdu1000-idp.dts | 26 ++++++++++++++++++++++++
>>>>>   1 file changed, 26 insertions(+)
>>>>>
>>>>> diff --git a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
>>>>> index 1d22f87fd238..3f5512ec0a90 100644
>>>>> --- a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
>>>>> +++ b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
>>>>> @@ -448,6 +448,32 @@ &qupv3_id_0 {
>>>>>          status = "okay";
>>>>>   };
>>>>>
>>>>> +&reserved_memory{
>>>>> +       #address-cells = <2>;
>>>>> +       #size-cells = <2>;
>>>>> +       ranges;
>>>>> +
>>>>> +       ecc_meta_data_reserved_mem:ecc_meta_data_reserved_region@e0000000{
>>>> no_underscores_in_node_names. Ever.
>>>>
>>>> Also, if you have checked other platforms, you'd have seen that other
>>>> platforms use a much more generic node name for 'memory' nodes (which
>>>> you should have used too).
>>>
>>> These memory nodes are new to QDU platform, so will it be okay if I keep
>>> these names without region suffix?
>>
>> Just use 'memory@abcd'.
> Documentation/devicetree/bindings/reserved-memory/reserved-memory.yaml
> 
>   Following the generic-names recommended practice, node names should
>   reflect the purpose of the node (ie. "framebuffer" or "dma-pool").
>   Unit address (@<address>) should be appended to the name if the node
>   is a static allocation.
> 

Yeah, two minutes too late :)

Best regards,
Krzysztof