Re: [PATCH] arm64: dts: imx8mn-var-som-symphony: fix USB OTG

From: Nate Drude
Date: Wed Jul 05 2023 - 09:42:11 EST




On 7/5/23 8:35 AM, Hugo Villeneuve wrote:
> [Some people who received this message don't often get email from hugo@xxxxxxxxxxx. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> On Tue, 4 Jul 2023 20:00:13 -0300
> Fabio Estevam <festevam@xxxxxxxxx> wrote:
>
>> On Tue, Jul 4, 2023 at 6:50 PM Fabio Estevam <festevam@xxxxxxxxx> wrote:
>>>
>>> On Tue, Jul 4, 2023 at 6:28 PM Hugo Villeneuve <hugo@xxxxxxxxxxx> wrote:
>>>
>>>> Hi Fabio,
>>>> it is important to remember that on this board, like I explained
>>>> before, the INTB pin is not connected to anything.
>>>>
>>>> It is only the ID pin (9) that is connected to the GPIO1_11 pin.
>>>
>>> Now I looked at the schematics and you are right.
>>>
>>> In this case, GPIO1_11 should not be represented as irq then.
>>
>> Variscite added an "irq-is-id-quirk" property on their tree to handle this:
>>
>> https://github.com/varigit/linux-imx/commit/fbe6aa2a9c014fdb10b29a715a1be695dac60828
>
> Hi Fabio,
> what do you think of Variscite's patch, is it something
> worth doing?
>
> At least the comment is interesting about the different EVK board
> versions: mine is v1.6, which confirms the connection of the ID pin to
> the GPIO1_11 pin. This also means that old boards have a connection from
> the IRQ pin to GPIO1_11, and for these older boards the DTS is probably
> Ok as it is?
>
> How can we support both configurations?
>
> Hugo.
>
>
The patch 'drivers: extcon: ptn5150: Add irq-is-id-quirk' referred to by Fabio is required for OTG to work correctly on all versions of the Symphony board.

I can submit this patch mainline, do you think it will be accepted as is?

Thanks,
Nate