Re: [PATCH] PCI: rcar-ep: Include linux/pci-epf.h instead of linux/pci-epc.h

From: Krzysztof Wilczyński
Date: Wed Jul 05 2023 - 07:44:52 EST


Hello,

> > pci-epc.h doesn't define the members of the pci_epf_header struct, so
> > trying to access them results in errors like this:
> >
> > error: invalid use of undefined type 'struct pci_epf_header'
> > 167 | val = hdr->vendorid;
> >
> > Instead let's include pci-epf.h which not only defines the
> > pci_epf_header but also includes pci-epc.h.

[...]
> It is odd that the the build bot did not detect this...

This is a bit of a surprise to me too, especially since none of the usual
bots pick this up, and I can't seem to find such a failure in the nightly
CI logs either.

Alistair, how did you stumble into this issue? Also, which version or
a tree would that be?

Thank you!

Krzysztof