Re: [PATCH 1/2] arm64: dts: qcom: qdu1000-idp: Update reserved memory region

[Dmitry Baryshkov]

On Wed, 5 Jul 2023 at 10:06, Komal Bajaj <quic_kbajaj@xxxxxxxxxxx> wrote:
>
>
>
> On 7/5/2023 11:19 AM, Dmitry Baryshkov wrote:
> > On Wed, 5 Jul 2023 at 08:40, Komal Bajaj <quic_kbajaj@xxxxxxxxxxx> wrote:
> >> Add missing reserved regions as described in QDU1000 memory map.
> >>
> >> Signed-off-by: Komal Bajaj <quic_kbajaj@xxxxxxxxxxx>
> >> ---
> >>   arch/arm64/boot/dts/qcom/qdu1000-idp.dts | 26 ++++++++++++++++++++++++
> >>   1 file changed, 26 insertions(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
> >> index 1d22f87fd238..3f5512ec0a90 100644
> >> --- a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
> >> +++ b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
> >> @@ -448,6 +448,32 @@ &qupv3_id_0 {
> >>          status = "okay";
> >>   };
> >>
> >> +&reserved_memory{
> >> +       #address-cells = <2>;
> >> +       #size-cells = <2>;
> >> +       ranges;
> >> +
> >> +       ecc_meta_data_reserved_mem:ecc_meta_data_reserved_region@e0000000{
> > no_underscores_in_node_names. Ever.
> >
> > Also, if you have checked other platforms, you'd have seen that other
> > platforms use a much more generic node name for 'memory' nodes (which
> > you should have used too).
>
> These memory nodes are new to QDU platform, so will it be okay if I keep
> these names without region suffix?

Just use 'memory@abcd'.

>
> Thanks
> Komal
>
> >
> >> +               no-map;
> >> +               reg = <0x0 0xe0000000 0x0 0x20000000>;
> >> +       };
> >> +
> >> +       harq_buffer_mem:harq_buffer_region@800000000{
> >> +               no-map;
> >> +               reg = <0x8 0x0 0x0 0x80000000>;
> >> +       };
> >> +
> >> +       tenx_sp_buffer_mem:tenx_sp_buffer_region@880000000{
> >> +               no-map;
> >> +               reg = <0x8 0x80000000 0x0 0x50000000>;
> >> +       };
> >> +
> >> +       fapi_buffer_mem:fapi_buffer_region@8d0000000{
> >> +               no-map;
> >> +               reg = <0x8 0xd0000000 0x0 0x20000000>;
> >> +       };
> >> +};
> >> +
> >>   &sdhc {
> >>          pinctrl-0 = <&sdc_on_state>;
> >>          pinctrl-1 = <&sdc_off_state>;
> >> --
> >> 2.40.1
> >>
> >
>


-- 
With best wishes
Dmitry