Re: [PATCH 2/3] drm/panel: ld9040: Register a backlight device

[Paul Cercueil]

Hi Inki,

Le mardi 04 juillet 2023 à 08:49 +0900, 대인기/Tizen Platform Lab(SR)/삼성전자
a écrit :
> Hi,
> 
> > -----Original Message-----
> > From: dri-devel <dri-devel-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf
> > Of
> > Paul Cercueil
> > Sent: Tuesday, July 4, 2023 6:47 AM
> > To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>; Rob
> > Herring
> > <robh+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>; Alim
> > Akhtar
> > <alim.akhtar@xxxxxxxxxxx>; Neil Armstrong
> > <neil.armstrong@xxxxxxxxxx>; Sam
> > Ravnborg <sam@xxxxxxxxxxxx>
> > Cc: devicetree@xxxxxxxxxxxxxxx; linux-samsung-soc@xxxxxxxxxxxxxxx;
> > linux-
> > kernel@xxxxxxxxxxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx; Paul
> > Cercueil
> > <paul@xxxxxxxxxxxxxxx>; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> > Subject: [PATCH 2/3] drm/panel: ld9040: Register a backlight device
> > 
> > Register a backlight device to be able to switch between all the
> > gamma
> > levels.
> > 
> > Signed-off-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx>
> > ---
> >  drivers/gpu/drm/panel/panel-samsung-ld9040.c | 40
> > ++++++++++++++++++++
> >  1 file changed, 40 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/panel/panel-samsung-ld9040.c
> > b/drivers/gpu/drm/panel/panel-samsung-ld9040.c
> > index 7fd9444b42c5..b4f87d6244cb 100644
> > --- a/drivers/gpu/drm/panel/panel-samsung-ld9040.c
> > +++ b/drivers/gpu/drm/panel/panel-samsung-ld9040.c
> > @@ -8,6 +8,7 @@
> >   * Andrzej Hajda <a.hajda@xxxxxxxxxxx>
> >  */
> > 
> > +#include <linux/backlight.h>
> >  #include <linux/delay.h>
> >  #include <linux/gpio/consumer.h>
> >  #include <linux/module.h>
> > @@ -311,8 +312,40 @@ static int ld9040_parse_dt(struct ld9040 *ctx)
> >         return 0;
> >  }
> > 
> > +static int ld9040_bl_update_status(struct backlight_device *dev)
> > +{
> > +       struct ld9040 *ctx = dev_get_drvdata(&dev->dev);
> > +
> > +       ctx->brightness = dev->props.brightness;
> > +       ld9040_brightness_set(ctx);
> > +
> > +       return 0;
> > +}
> > +
> > +static int ld9040_bl_get_intensity(struct backlight_device *dev)
> > +{
> > +       if (dev->props.fb_blank == FB_BLANK_UNBLANK &&
> 
> fb_blank member is deprecated according to the description of
> backlight.h
> file so you could drop above condition I think.

Thanks. I'll send a V2.

Cheers,
-Paul