Re: [PATCH v8 05/14] mfd: rk808: split into core and i2c

From: Geert Uytterhoeven
Date: Tue Jul 04 2023 - 09:08:26 EST


Hi Sebastian,

On Fri, Jun 30, 2023 at 8:48 PM Sebastian Reichel
<sebastian.reichel@xxxxxxxxxxxxx> wrote:
> On Fri, Jun 30, 2023 at 01:34:44PM +0200, Geert Uytterhoeven wrote:
> > > --- a/drivers/mfd/Kconfig
> > > +++ b/drivers/mfd/Kconfig
> > > @@ -1183,12 +1183,17 @@ config MFD_RC5T583
> > > Additional drivers must be enabled in order to use the
> > > different functionality of the device.
> > >
> > > -config MFD_RK808
> > > +config MFD_RK8XX
> > > + bool
> >
> > Is there any specific reason why this cannot be modular, like most (all?)
> > of its users that select it?
>
> I don't remember why I made that bool. Tristate should be perfectly
> fine. Do you want to send a patch (I will test it of course), or should
> I take care of it?

I have sent a patch.
https://lore.kernel.org/r/d132363fc9228473e9e652b70a3761b94de32d70.1688475844.git.geert+renesas@xxxxxxxxx

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds