Fix a coverity issue:
larbid = MTK_M4U_TO_LARB(fwspec->ids[0]);assignment: Assigning: larbid = (fwspec->ids[0] >> 5) & 0x1fU.
if (larbid >= MTK_LARB_NR_MAX)between: At condition larbid >= 32U, the value of larbid must be between
0 and 31.
dead_error_condition: The condition larbid >= 32U cannot be true.
return ERR_PTR(-EINVAL);CID 11306470 (#1 of 1): Logically dead code (DEADCODE)
dead_error_line: Execution cannot reach this statement:
return ERR_PTR(-22L);
The checking "if (larbid >= MTK_LARB_NR_MAX)" is unnecessary.
Signed-off-by: Yong Wu <yong.wu@xxxxxxxxxxxx>
---
Rebase on v6.4-rc1.
---
drivers/iommu/mtk_iommu.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c
index aecc7d154f28..67caa90b481b 100644
--- a/drivers/iommu/mtk_iommu.c
+++ b/drivers/iommu/mtk_iommu.c
@@ -838,9 +838,6 @@ static struct iommu_device *mtk_iommu_probe_device(struct device *dev)
* All the ports in each a device should be in the same larbs.
*/
larbid = MTK_M4U_TO_LARB(fwspec->ids[0]);
- if (larbid >= MTK_LARB_NR_MAX)
- return ERR_PTR(-EINVAL);
-
for (i = 1; i < fwspec->num_ids; i++) {
larbidx = MTK_M4U_TO_LARB(fwspec->ids[i]);
if (larbid != larbidx) {