Re: [PATCH] nvme:fix the NVME_ID_NS_NVM_STS_MASK definition

[Kanchan Joshi]

On Fri, Jun 23, 2023 at 06:08:05PM +0530, Ankit Kumar wrote:
> As per NVMe command set specification 1.0c Storage tag size is 7 bits
> Fixes: 4020aad85c67 ("nvme: add support for enhanced metadata")
>
> Signed-off-by: Ankit Kumar <ankit.kumar@xxxxxxxxxxx>
> ---
> include/linux/nvme.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/nvme.h b/include/linux/nvme.h
> index 779507ac750b..2819d6c3a6b5 100644
> --- a/include/linux/nvme.h
> +++ b/include/linux/nvme.h
> @@ -473,7 +473,7 @@ struct nvme_id_ns_nvm {
> };
>
> enum {
> -	NVME_ID_NS_NVM_STS_MASK		= 0x3f,
> +	NVME_ID_NS_NVM_STS_MASK		= 0x7f,

Right, 7 bits are needed there to speak the max possible value (i.e.,64).

Reviewed-by: Kanchan Joshi <joshi.k@xxxxxxxxxxx>