Re: [PATCH] mm: page_alloc: avoid false page outside zone error info

From: Matthew Wilcox
Date: Tue Jul 04 2023 - 08:14:14 EST


On Tue, Jul 04, 2023 at 07:18:23PM +0800, Miaohe Lin wrote:
> @@ -470,6 +470,8 @@ static int page_outside_zone_boundaries(struct zone *zone, struct page *page)
> sp = zone->spanned_pages;
> if (!zone_spans_pfn(zone, pfn))
> ret = 1;
> + else
> + ret = 0;

Surely 'ret = zone_spans_pfn(zone, pfn);' ?

Also, did you spot this by inspection or do you have a test-case or bug
report? Should this have a Fixes: tag?