Re: [PATCH v3 0/4] Fix up the boe-tv101wum-nl6 panel driver

[cong yang]

Hi,

On Tue, Jul 4, 2023 at 6:16 PM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
>
> On Tue, Jul 4, 2023 at 12:04 PM cong yang
> <yangcong5@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> > On Mon, Jul 3, 2023 at 9:21 PM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
>
> > > I am surprised that contributors from manufacturers do not seem
> > > to have datasheets for the display controllers embedded in the
> > > panels of their products. Can you take a second look?
> >
> > Sorry, this panel datasheet is not open source, I can't share this datasheet.
>
> Perhaps not, but you can use the knowledge in the datasheet to
> name the commands and give better structure to the members of
> the driver, if you know what commands mean then provide
> #define statements to them so sequences become understandable.
> See for example patch 4/4.

Patch 4/4 LGTM, from the datasheet  0XFF is EXTC Command Set Enable .
Description: Set the register, 1 Parameter = 98h, 2 Parameter = 82h, 3
Parameter = Page value to enable “page command set” available.
00h = Page 0 ,01h = Page 1... 0Eh = Page 14.

Thank you for you patch.
>
> Yours,
> Linus Walleij