Re: [PATCH v6 8/8] soc: mediatek: pm-domains: Add support for MT8365

[AngeloGioacchino Del Regno]

Il 27/06/23 15:10, Markus Schneider-Pargmann ha scritto:
> From: Fabien Parent <fparent@xxxxxxxxxxxx>
>
> Add the needed board data to support MT8365 SoC.
>
> Signed-off-by: Fabien Parent <fparent@xxxxxxxxxxxx>
> Signed-off-by: Markus Schneider-Pargmann <msp@xxxxxxxxxxxx>



..snip..


> diff --git a/include/linux/soc/mediatek/infracfg.h b/include/linux/soc/mediatek/infracfg.h
> index 07f67b3d8e97..f853397697b5 100644
> --- a/include/linux/soc/mediatek/infracfg.h
> +++ b/include/linux/soc/mediatek/infracfg.h
> @@ -2,6 +2,47 @@
>   #ifndef __SOC_MEDIATEK_INFRACFG_H
>   #define __SOC_MEDIATEK_INFRACFG_H
>   
> +#define MT8365_INFRA_TOPAXI_PROTECTEN_STA1				0x228
> +#define MT8365_INFRA_TOPAXI_PROTECTEN_SET				0x2a0
> +#define MT8365_INFRA_TOPAXI_PROTECTEN_CLR				0x2a4
> +# define MT8365_INFRA_TOPAXI_PROTECTEN_MM_M0				BIT(1)

Personally, I like this kind of indentation, but more like

#define REGADDRESS
 #define REGMASK

instead of

#define REGADDRESS
# define REGMASK

...but this doesn't count, because this header doesn't follow *either* formats,
not my preferred, nor yours: this means that, for consistency, you have to follow
what's in there already, so you have to change that to

#define REGADDRESS
#define REGMASK

...so please change that to retain consistency across the infracfg.h header,
after which:

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>

P.S.: I'm sorry for not noticing this in v5.

Cheers,
Angelo