Re: [PATCH v4] crypto: qat - Replace the if statement with min()

From: Andy Shevchenko
Date: Tue Jul 04 2023 - 03:56:54 EST


On Tue, Jul 04, 2023 at 07:45:42AM +0000, 尤康仁 wrote:
> Hi Andy,
>
> Can you tell me what is your tag? I haven't found it in Re: [PATCH v3]
> crypto: qat - Replace the if statement with min()

Please, avoid top-postings.

Tag in this case is the line started with Reviewed-by:.

Please, read this [1] to get familiar with the tags and process.
And be respectful to the reviewers in the future.

[1]: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes

> -----Original email-----
> On Tue, Jul 04, 2023 at 02:56:39PM +0800, You Kangren wrote:
> > mark UWORD_CPYBUF_SIZE with U suffix to make the type the same with
>
> You need to respect English grammar and punctuation.
> Here should be
>
> Mark...
>
> > words_num and replace the if statement with min() in
>
> (drop trailing space)
>
> > qat_uclo_wr_uimage_raw_page() to make code shorter
>
> ...and here the period is missing.
>
> Also, Haven't I given my tag? Why it's not added?
>
> > Signed-off-by: You Kangren <youkangren@xxxxxxxx>
> > ---
>
> Where is the changelog from v3? What had been changed so far?

--
With Best Regards,
Andy Shevchenko