Re: [PATCH] riscv: entry: Fixup do_trap_break from kernel side

[Guo Ren]

On Mon, Jul 3, 2023 at 6:29 PM Daniel Thompson
<daniel.thompson@xxxxxxxxxx> wrote:
>
> On Sat, Jul 01, 2023 at 10:57:07PM -0400, guoren@xxxxxxxxxx wrote:
> > From: Guo Ren <guoren@xxxxxxxxxxxxxxxxx>
> >
> > The irqentry_nmi_enter/exit would force the current context into in_interrupt.
> > That would trigger the kernel to dead panic, but the kdb still needs "ebreak" to
> > debug the kernel.
> >
> > Move irqentry_nmi_enter/exit to exception_enter/exit could correct handle_break
> > of the kernel side.
>
> <snip>
>
> > Fixes: f0bddf50586d ("riscv: entry: Convert to generic entry")
> > Reported-by: Daniel Thompson <daniel.thompson@xxxxxxxxxx>
> > Signed-off-by: Guo Ren <guoren@xxxxxxxxxxxxxxxxx>
> > Signed-off-by: Guo Ren <guoren@xxxxxxxxxx>
> > Cc: stable@xxxxxxxxxxxxxxx
>
> I pushed this though the kgdb test suite that originally found the
> problem (although it didn't occur to me when I reported it that
> the problem was nothing to do with kgdb ;-) ). So FWIW:
>
> Tested-by: Daniel Thompson <daniel.thompson@xxxxxxxxxx>
Thx for the report & tested-by.

>
>
> Daniel.



-- 
Best Regards
 Guo Ren