Re: [PATCH 3/4] pinctrl: amd: Unify debounce handling into amd_pinconf_set()

[Mario Limonciello]

On 7/3/23 16:33, andy.shevchenko@xxxxxxxxx wrote:
> Fri, Jun 30, 2023 at 02:47:15PM -0500, Mario Limonciello kirjoitti:
> > Debounce handling is done in two different entry points in the driver.
> > Unify this to make sure that it's always handled the same.
>
> ...
>
> > -static int amd_gpio_set_debounce(struct gpio_chip *gc, unsigned offset,
> > -		unsigned debounce)
> > +static int amd_gpio_set_debounce(struct amd_gpio *gpio_dev, unsigned offset,
> > +				 unsigned debounce)
>
> Side note: Are you going to fix unsigned --> unsigned int?
> The former is discouraged.
>
> ...
>
> > +out:
>
> out_unlock: ?
>
> >   	raw_spin_unlock_irqrestore(&gpio_dev->lock, flags);
> >   
> >   	return ret;

Ack, thanks will adjust both.