Re: [PATCH v1] arch: free dev before return

[Max Filippov]

On Mon, Jul 3, 2023 at 7:19 AM Max Filippov <jcmvbkbc@xxxxxxxxx> wrote:
> On Mon, Jul 3, 2023 at 5:33 AM Minjie Du <duminjie@xxxxxxxx> wrote:
> >
> > We fixed a bug where the variable dev
> > was not freed before return.
> >
> > Signed-off-by: Minjie Du <duminjie@xxxxxxxx>
> > ---
> >  arch/xtensa/platforms/iss/network.c | 1 +
> >  1 file changed, 1 insertion(+)
>
> Applied to my xtensa tree with the following commit message:
>
>    xtensa: ISS: fix etherdev leak in error return path
>
>    iss_net_configure frees etherdev in all error return paths except one
>    where register_netdevice fails. Add missing free_netdev to that path.
>

After testing it I realized that in that error return path the etherdev is
freed by the iss_net_pdev_release callback and that this patch
introduces freeing an active timer on that path. I've dropped this patch
and committed another one that adds a comment about what's going
on at that place.

-- 
Thanks.
-- Max