Re: [PATCH v3] btf: warn but return no error for NULL btf from __register_btf_kfunc_id_set()

[Daniel Borkmann]

On 7/1/23 7:14 PM, SeongJae Park wrote:
> __register_btf_kfunc_id_set() assumes .BTF to be part of the module's
> .ko file if CONFIG_DEBUG_INFO_BTF is enabled.  If that's not the case,
> the function prints an error message and return an error.  As a result,
> such modules cannot be loaded.
>
> However, the section could be stripped out during a build process.  It
> would be better to let the modules loaded, because their basic
> functionalities have no problem[1], though the BTF functionalities will
> not be supported.  Make the function to lower the level of the message
> from error to warn, and return no error.
>
> [1] https://lore.kernel.org/bpf/20220219082037.ow2kbq5brktf4f2u@apollo.legion/
>
> Reported-by: Alexander Egorenkov <Alexander.Egorenkov@xxxxxxx>
> Link: https://lore.kernel.org/bpf/87y228q66f.fsf@xxxxxxxxxxxxxxxxxxxx/
> Suggested-by: Kumar Kartikeya Dwivedi <memxor@xxxxxxxxx>
> Link: https://lore.kernel.org/bpf/20220219082037.ow2kbq5brktf4f2u@apollo.legion/
> Fixes: c446fdacb10d ("bpf: fix register_btf_kfunc_id_set for !CONFIG_DEBUG_INFO_BTF")
> Cc: <stable@xxxxxxxxxxxxxxx> # 5.18.x
> Signed-off-by: SeongJae Park <sj@xxxxxxxxxx>
> Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx>
> Signed-off-by: SeongJae Park <sj@xxxxxxxxxx>
> ---
>
> Changes from v2
> (https://lore.kernel.org/bpf/20230628164611.83038-1-sj@xxxxxxxxxx/)
> - Keep the error for vmlinux case.

Looks good, applied to bpf, thanks!