Re: [PATCH v3 3/3] dt-bindings: hwmon: add sht3x devicetree binding

[Krzysztof Kozlowski]

On 03/07/2023 16:08, JuenKit Yip wrote:
> add sht3x devicetree binding files
> 
> Signed-off-by: JuenKit Yip <JuenKit_Yip@xxxxxxxxxxx>
> ---
> v3:
>   - fix wildcards problem
>   - add vdd-supply property

No improvements in subject.
> 
>  .../bindings/hwmon/sensirion,sht3x.yaml       | 45 +++++++++++++++++++
>  1 file changed, 45 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/sensirion,sht3x.yaml
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/sensirion,sht3x.yaml b/Documentation/devicetree/bindings/hwmon/sensirion,sht3x.yaml
> new file mode 100644
> index 000000000000..bef2eb492a47
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/sensirion,sht3x.yaml
> @@ -0,0 +1,45 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/sensirion,sht3x.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sensirion SHT3x-DIS humidity and temperature sensor
> +
> +maintainers:
> +  - JuenKit Yip <JuenKit_Yip@xxxxxxxxxxx>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - sensirion,sht30
> +      - sensirion,sht31
> +      - sensirion,sht35
> +      - sensirion,sts30
> +      - sensirion,sts31
> +      - sensirion,sts35

Your driver change suggests these are compatible, so make them such with
oneOf and a list.

> +
> +  reg:
> +    maxItems: 1
> +  
> +  vdd-supply:
> +    description: regulator that drives the VDD pin

Missing reset-gpios. It's the second ignored comment.

This is a friendly reminder during the review process.

It seems my previous comments were not fully addressed. Maybe my
feedback got lost between the quotes, maybe you just forgot to apply it.
Please go back to the previous discussion and either implement all
requested changes or keep discussing them.

Thank you.


Best regards,
Krzysztof