Re: [PATCH] ASoC: qdsp6: q6apm: use dai link pcm id as pcm device number

From: Johan Hovold
Date: Mon Jul 03 2023 - 04:49:01 EST


On Mon, Jul 03, 2023 at 10:19:29AM +0200, Takashi Iwai wrote:
> On Mon, 03 Jul 2023 10:03:52 +0200,
> Johan Hovold wrote:

> > Ok, scratch that. I just hit the race again also with this patch
> > applied:
> >
> > [ 11.815028] q6apm-dai 3000000.remoteproc:glink-edge:gpr:service@1:dais: Adding to iommu group 23
> > [ 11.838667] snd-sc8280xp sound: ASoC: adding FE link failed
> > [ 11.838774] snd-sc8280xp sound: ASoC: topology: could not load header: -517
> > [ 11.838916] qcom-apm gprsvc:service:2:1: tplg component load failed-517
> > [ 11.838996] qcom-apm gprsvc:service:2:1: ASoC: error at snd_soc_component_probe on gprsvc:service:2:1: -22
> > [ 11.839430] snd-sc8280xp sound: ASoC: failed to instantiate card -22
> > [ 11.844801] snd-sc8280xp: probe of sound failed with error -22
>
> Isn't it rather an issue about the error code passing in qcom driver?
> How about the change like below?

Indeed, and I tested a change like that here:

https://lore.kernel.org/lkml/ZIHSGf18Aw7htb9o8@xxxxxxxxxxxxxxxxxxxx/

but that only seems to make the problem worse currently.

This should probably still be fixed, but I was just hoping that the DAI
numbering could have been the cause for the probe deferral (which then
triggers the other bugs).

Johan